Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-4851: Remove All Calls To printStackTrace #1783

Closed
wants to merge 1 commit into from
Closed

THRIFT-4851: Remove All Calls To printStackTrace #1783

wants to merge 1 commit into from

Conversation

belugabehr
Copy link
Contributor

Remove All Calls To printStackTrace

@Jens-G
Copy link
Member

Jens-G commented Apr 17, 2019

LGTM, not tested

nandorKollar
nandorKollar approved these changes May 3, 2019
View reviewed changes
Copy link

@nandorKollar nandorKollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jens-G
Copy link
Member

Jens-G commented May 3, 2019

Just noticed:is there a specific reason why in some cases it is

LoggerFactory.getLogger(TServerSocket.class.getName());

and in other cases just

LoggerFactory.getLogger(TSaslTransport.class);

without "getName()"?

@Jens-G Jens-G closed this in cc13de4 May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandorKollar nandorKollar nandorKollar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@belugabehr @Jens-G @nandorKollar