Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-4945 Log output mode is not standardized #1862

Merged
merged 1 commit into from Oct 8, 2019
Merged

THRIFT-4945 Log output mode is not standardized #1862

merged 1 commit into from Oct 8, 2019

Conversation

Issacpeng
Copy link
Contributor

@Issacpeng Issacpeng commented Aug 31, 2019 •
edited

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, add [skip ci] at the end of your pull request to free up build resources.

qinghui-xu
qinghui-xu approved these changes Sep 21, 2019
View reviewed changes
Copy link
Contributor

@qinghui-xu qinghui-xu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dcelasun dcelasun merged commit a152a0a into apache:master Oct 8, 2019
@dcelasun
Copy link
Member

dcelasun commented Oct 8, 2019

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinghui-xu qinghui-xu qinghui-xu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Issacpeng @dcelasun @qinghui-xu