Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NodeJS to cmake #2026

Closed
wants to merge 2 commits into from
Closed

Add NodeJS to cmake #2026

wants to merge 2 commits into from

Conversation

emmenlau
Copy link
Member

This PR adds NodeJS to the cmake build. NodeJS does not have an actual autotools build target, only dependencies installation, tests, linting, and installation. Not all targets of the autotools build are included. However the relevant section to install NodeJS dependencies and the NodeJS install are included.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, add [skip ci] at the end of your pull request to free up build resources.

@Jens-G Jens-G closed this in 61d5020 Feb 23, 2020
@emmenlau emmenlau deleted the bda_add_nodejs_to_cmake branch February 24, 2020 09:44
Jens-G added a commit to Jens-G/thrift that referenced this pull request Feb 27, 2020
@Jens-G
revert apache#2025
c9e08e7 
revert apache#2026
Jens-G added a commit to Jens-G/thrift that referenced this pull request Feb 27, 2020
@Jens-G
reverted apache#2025
2fd1cd2 
reverted apache#2026
Jens-G added a commit to Jens-G/thrift that referenced this pull request Feb 28, 2020
@Jens-G
reverted apache#2025
f6d3e75 
reverted apache#2026
Jens-G added a commit that referenced this pull request Feb 28, 2020
@Jens-G
CI broken, reverting following PRs
1b7b00c 
reverted #2025
reverted #2026
Reverted #2021
emmenlau added a commit to BioDataAnalysis/thrift that referenced this pull request Apr 8, 2020
@emmenlau
THRIFT-5109 Misc Cmake build improvements
6dcb219 
Patch: Mario Emmenlauer

This closes apache#2026
This closes apache#2025
This closes apache#2021
@emmenlau emmenlau mentioned this pull request Apr 8, 2020
Closed
5 tasks
emmenlau added a commit to BioDataAnalysis/thrift that referenced this pull request Apr 8, 2020
@emmenlau
THRIFT-5109 Misc Cmake build improvements
481df2b 
Patch: Mario Emmenlauer

This closes apache#2026
This closes apache#2025
This closes apache#2021
emmenlau added a commit to BioDataAnalysis/thrift that referenced this pull request Apr 8, 2020
@emmenlau
THRIFT-5109 Misc Cmake build improvements
a4a4d4b 
Patch: Mario Emmenlauer

This closes apache#2026
This closes apache#2025
This closes apache#2021
emmenlau added a commit to BioDataAnalysis/thrift that referenced this pull request Apr 8, 2020
@emmenlau
THRIFT-5109 Misc Cmake build improvements
d50f34b 
Patch: Mario Emmenlauer

This closes apache#2026
This closes apache#2025
This closes apache#2021
emmenlau added a commit to BioDataAnalysis/thrift that referenced this pull request Apr 15, 2020
@emmenlau
THRIFT-5109 Misc Cmake build improvements
09e0990 
Patch: Mario Emmenlauer

This closes apache#2026
This closes apache#2025
This closes apache#2021
emmenlau added a commit to BioDataAnalysis/thrift that referenced this pull request Apr 17, 2020
@emmenlau
THRIFT-5109 Misc Cmake build improvements
8e0764e 
Patch: Mario Emmenlauer

This closes apache#2026
This closes apache#2025
This closes apache#2021
emmenlau added a commit to BioDataAnalysis/thrift that referenced this pull request Apr 19, 2020
@emmenlau
THRIFT-5109 Misc Cmake build improvements
cfc83c0 
Patch: Mario Emmenlauer

This closes apache#2026
This closes apache#2025
This closes apache#2021
emmenlau added a commit to BioDataAnalysis/thrift that referenced this pull request Apr 20, 2020
@emmenlau
THRIFT-5109 Misc Cmake build improvements
697fe3e 
Patch: Mario Emmenlauer

This closes apache#2026
This closes apache#2025
This closes apache#2021
emmenlau added a commit to BioDataAnalysis/thrift that referenced this pull request Apr 20, 2020
@emmenlau
THRIFT-5109 Misc Cmake build improvements
3ca3274 
Patch: Mario Emmenlauer

This closes apache#2026
This closes apache#2025
This closes apache#2021
emmenlau added a commit to BioDataAnalysis/thrift that referenced this pull request Apr 21, 2020
@emmenlau
THRIFT-5109 Misc Cmake build improvements
8af9f7b 
Patch: Mario Emmenlauer

This closes apache#2026
This closes apache#2025
This closes apache#2021
sveneld pushed a commit to sveneld/thrift that referenced this pull request May 29, 2020
@emmenlau
THRIFT-5109 Misc Cmake build improvements
073ede3 
Patch: Mario Emmenlauer

This closes apache#2026
This closes apache#2025
This closes apache#2021
sveneld pushed a commit to sveneld/thrift that referenced this pull request May 29, 2020
@Jens-G
CI broken, reverting following PRs
96a35fa 
reverted apache#2025
reverted apache#2026
Reverted apache#2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@emmenlau