THRIFT-5116: Update NodeJS to supported version on Ubuntu Xenial

[emmenlau]

This PR updates NodeJS on Ubuntu Xenial to 10.x. This is because NodeJS 6.x that was previously used does not support newer node modules. Also, since January 2020, NodeJS 8.x is EOL. Therefore 10.x is the currently oldest, supported NodeJS version.

The Dockerfile was tested locally so the docker build should work. Also, NodeJS is the currently successfully employed version on other thrift docker builds.

This PR fixes the issue https://travis-ci.org/apache/thrift/jobs/654070652 that is now solved in https://travis-ci.org/apache/thrift/jobs/654644828, so please review and merge. However note that the build still does not fully succeed with a later error about a required Ruby update. This second issue is very likely unrelated to this PR.

• Apache Jira ticket THRIFT-5116
• If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
• Did you squash your changes to a single commit? (not required, but preferred)
• Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
• If your change does not involve any code, add [skip ci] at the end of your pull request to free up build resources.

[Jens-G]

Is that related to / superseded by THRIFT-5120 maybe?

[emmenlau]

I'm not really an expert, but I think this PR supersedes THRIFT-5120. THRIFT-5120 uses Node 8.x which since January 2020 is EOL. I think it may be better to go for the currently supported Node versions, or what do you think?

[dcelasun]

Please also update LANGUAGES.md and CHANGES.md.

[emmenlau]

Thanks @dcelasun, fixed now. Please review.

[dcelasun]

Unfortunately this seems to have broken Travis:

Rebuilding docker image ubuntu-xenial
Sending build context to Docker daemon 11.26kB
Error response from daemon: Dockerfile parse error line 60: unknown instruction: APT-ADD-REPOSITORY
The command "if [[ uname == "Linux" ]]; then build/docker/refresh.sh; fi" failed and exited with 1 during .

[emmenlau]

Unfortunately this seems to have broken Travis:

Error response from daemon: Dockerfile parse error line 60: unknown instruction: APT-ADD-REPOSITORY
The command "if [[ uname == "Linux" ]]; then build/docker/refresh.sh; fi" failed and exited with 1 during .

Possibly you are right, but I've just seen a very similar error in an unrelated build. Could you pelase re-trigger Travis once to see if that helps? See also my related email to dev-list from today.

[dcelasun]

I've restarted it and it failed again, because there really is a bug 🙂 This:

echo "deb https://deb.nodesource.com/node_10.x xenial main" | tee /etc/apt/sources.list.d/nodesource.list

should be

echo "deb https://deb.nodesource.com/node_10.x xenial main" | tee /etc/apt/sources.list.d/nodesource.list && \

(note the && \ at the end)

[emmenlau]

Dammit, you are right! Thanks.

Slightly off-topic, I think the comments in the Dockerfile should really be changed. I've had good experience with adding comments in chains of && via echo. So instead of

# dotnet (core)
    curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \
    echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-xenial-prod xenial main" > \
      /etc/apt/sources.list.d/dotnetdev.list && \

# node.js
    curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add - && \
    echo "deb https://deb.nodesource.com/node_10.x xenial main" | tee /etc/apt/sources.list.d/nodesource.list && \

# ruby 2.4
    apt-add-repository ppa:brightbox/ruby-ng

I personally would highly prefer

    echo "Installing dotnet (core)" && \
    curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \
    echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-xenial-prod xenial main" > \
      /etc/apt/sources.list.d/dotnetdev.list && \
    echo "Installing node.js" && \
    curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add - && \
    echo "deb https://deb.nodesource.com/node_10.x xenial main" | tee /etc/apt/sources.list.d/nodesource.list && \
    echo "Installing ruby 2.4" && \
    apt-add-repository ppa:brightbox/ruby-ng

This does some part of documentation, remains visible in the execution, and most importantly it does not break the chain of &&-connections.

[dcelasun]

That's a great idea actually, please go ahead and change it.

[emmenlau]

Pushed again to re-trigger the CI. Please consider for merging if the build now succeeds?

[dcelasun]

Travis is all green, merged 🎉