Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5074: Crosstest client/server command line [skip ci] #2046

Closed

Conversation

janosvitok
Copy link
Contributor

@janosvitok janosvitok commented Mar 5, 2020

This matches the documentation to the actual interface.

The parameters have form --protocol=binary not --protocol binary

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, add [skip ci] at the end of your pull request to free up build resources.

@Jens-G
Copy link
Member

Jens-G commented Mar 22, 2020

Committed.

@Jens-G Jens-G closed this Mar 22, 2020
@janosvitok janosvitok deleted the update-readme branch March 22, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants