WIP: THRIFT-4547 Add Swift cross tests #2048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosvitok
changed the title
Linux version 4.2.0 does not have FileHandle.acceptConnectionInBackgroundAndNotify() implemented. We need at least 5.1 for TSocketServer to run in docker. In the meantime, URLRequest was moved to FoundationNetworking. To keep compatibility with previous versions, conditional import is used.
Requires these PRs: - apache#2036 - apache#2038 - apache#2047 Not finished, only few tests in client and server are implemented.
janosvitok
changed the title
janosvitok
changed the title
janosvitok
force-pushed
the
THRIFT-4547-swift-cross-tests
branch
from
4a1ffc5
to
a659108
Compare
5 tasks
Jens-G
requested changes
Mar 7, 2020
| /// - secondsToSleep: | ||
| /// - Throws: | ||
| func testOneway(secondsToSleep: Int32) throws { | ||
| } |
| /// - arg: | ||
| /// - Throws: Xception | ||
| func testException(arg: String) throws { | ||
| } |
| /// - Returns: Xtruct | ||
| /// - Throws: Xception, Xception2 | ||
| func testMultiException(arg0: String, arg1: String) throws -> Xtruct { | ||
| return Xtruct(string_thing: arg1, byte_thing: 0, i32_thing: 0, i64_thing: 0) |
|
Please cherty-pick only the first commit, the rest is not finished yet. See #2050 |
I noticed. That's why I deleted my comment :-) |
janosvitok
changed the title
5 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed due to inactivity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Work-in-progress implementation of Swift cross language test client and server.
Only few tests are implemented so far both in client and in server. The goal now was to write at least some test so that I can see if it at least partially works.
Requires #2038, #2047 to work.
Server does not work yet (in linux command line app; they do work in iOS app), notifications are not delivered from NotificationCenter and I don't know how to setup it properly.
This obviously introduces a lot of failures to the cross tests.
Any comments/improvemets are welcome!
[skip ci]at the end of your pull request to free up build resources.