THRIFT-5165: THttpClient saves session cookie. #2086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopedroantonio
force-pushed
the
THRIFT-5165
branch
2 times, most recently
from
db12528
to
ca2e46b
Compare
THttpClient saves the session cookie of an authenticated HTTP connection. When the Set-Cookie header is present in a response from the server, its value is saved in the headers of the http session, in the Cookie header.
joaopedroantonio
force-pushed
the
THRIFT-5165
branch
from
ca2e46b
to
b1e0f78
Compare
|
Hi @Jens-G , Could you clarify why you chose to close this PR? Thanks! |
|
@joaopedroantonio, Jens cherry-picked this commit to the master branch instead of merging this request. See the message: Jens-G closed this in 69642f3. If you check commit 69642f3, the contents is the same as your PR. Summary: your changes are in the master. |
|
Sorry guys, completely overlooked it! Thanks @janosvitok for clarifying and @Jens-G for the cherry-pick. :) |
sveneld
pushed a commit
to sveneld/thrift
that referenced
this pull request
May 29, 2020
Client: py Patch: Joao Antonio This closes apache#2086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THttpClient saves the session cookie of an authenticated HTTP
connection. When the Set-Cookie header is present in a response from the
server, its value is saved in the CustomHeaders in the Cookie header.
[skip ci]at the end of your pull request to free up build resources.