Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5217: Deprecated boost header #2158

Closed
wants to merge 1 commit into from

Conversation

zeshuai007
Copy link
Member

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@ulidtko
Copy link
Contributor

ulidtko commented May 28, 2020

Hey! I think you missed some files.

I'd fixed the same warning: c88fe54

My commit updates 17 files; yours only 11.

@ulidtko
Copy link
Contributor

ulidtko commented Jun 9, 2020

Hey! I think you missed some files.

Mmm, disregard that. I misread my files counts.

@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 8, 2020
@ulidtko
Copy link
Contributor

ulidtko commented Aug 8, 2020

This PR is ready for merge. @Stale undo

@stale
Copy link

stale bot commented Aug 8, 2020

This issue is no longer stale. Thank you for your contributions.

@stale stale bot removed the wontfix label Aug 8, 2020
@zeshuai007
Copy link
Member Author

.

@Jens-G Jens-G closed this in 6b1cb30 Sep 12, 2020
@emmenlau
Copy link
Member

Thanks @Jens-G !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants