Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5227: Update haskell build to cabal v2-* commands #2170

Closed
wants to merge 1 commit into from

Conversation

phile314
Copy link
Contributor

@phile314 phile314 commented Jun 4, 2020

Fixes the build with recent cabal versions.

I am not a cmake expert, so I just tried to get it working ...

If I do cmake && make check the tests pass. I do not seem to be able to call make cross, that target does not exist?

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 8, 2020
@stale
Copy link

stale bot commented Aug 15, 2020

This issue has been automatically closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant