Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5295 - makeThread and ThreadFactory extensible #2260

Closed

Conversation

rglarix
Copy link
Contributor

@rglarix rglarix commented Oct 14, 2020

Signed-off-by: rglarix rglarix@users.noreply.github.com

THRIFT-5295: This patch for cpp makes Thread and ThreadFactory customizable

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Signed-off-by: rglarix <rglarix@users.noreply.github.com>
@rglarix
Copy link
Contributor Author

rglarix commented Oct 15, 2020

Sorry, CI fails but it seems an appveyor problem still in the setup phase:
[00:01:11] downloading mingw-w64-x86_64-libevent-2.1.10-1-any.pkg.tar.xz...
[00:01:11] error: failed to commit transaction (unexpected error)
[00:01:11] Errors occurred, no packages were upgraded.
[00:01:11] Command exited with code 1

Something similar with travis, compilation of cpp was fine, I just cannot understand why it fails.

@Jens-G
Copy link
Member

Jens-G commented Dec 3, 2020

Could you give this one more try and force push, so a new CI run gets triggered?

@rglarix
Copy link
Contributor Author

rglarix commented Dec 7, 2020

done!

@Jens-G Jens-G closed this in 10f2556 Dec 8, 2020
@rglarix rglarix deleted the make-thread-threadfactory-extensible branch December 9, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants