THRIFT-3508: Map optional fields from thrift idl to optional fields i… #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n TypeScript. Client: node,js
|
So what are the next steps? Looks like CI is failing but not due to my code. |
What do we do with that one? |
|
After reading THRIFT-3227 again, I see that there might be actual usecases for the proposed split between classes and interfaces, although the original motivation is invalid now. So my suggestion is:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n TypeScript.
Client: node,js
Add ? behind optional members in classes if the field is marked as optional in thrift-idl.
Closes THRIFT-3508 and makes THRIFT-3227 probably obsolete as optional class members are supported since TypeScript 2.0
Did you create an Apache Jira ticket? (not required for trivial changes)
No, I am hijacking the existing Ticket of THRIFT-3508 as it is exactly what I implemented.
If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
Yes
Did you squash your changes to a single commit? (not required, but preferred)
Yes
Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
Yes, I am not aware of braking changes, but was unable to to do the Test drive development approach from the provided documentation.