THRIFT-5472: Retract bad go module version under lib/go/thrift #2468
Conversation
lib/go/thrift/go.mod
Outdated
|
|
||
| go 1.17 | ||
|
|
||
| // Accidentally pushed version with lib/go/thrift/go.mod, please update using `go get github.com/apache/thrift@latest`. |
There was a problem hiding this comment.
@dcelasun mainly asking for your review on the wording here :)
There was a problem hiding this comment.
Maybe include a link to the issue? Looks fine otherwise.
| // Accidentally pushed version with lib/go/thrift/go.mod, please update using `go get github.com/apache/thrift@latest`. | |
| // Accidentally pushed version with lib/go/thrift/go.mod, please update using `go get github.com/apache/thrift@latest`. | |
| // See https://github.com/golang/go/issues/49015 |
There was a problem hiding this comment.
@dcelasun I think the whole UI design around retract message display is for one-liners, I think it should be kept as short as possible and I'm not sure if two lines will break things. See https://pkg.go.dev/github.com/fishy/test-go-mod-retract/lib@v0.0.1-retract and
$ go get github.com/fishy/test-go-mod-retract/lib@v0.0.1-retract
go: downloading github.com/fishy/test-go-mod-retract/lib v0.0.1-retract
go: warning: github.com/fishy/test-go-mod-retract/lib@v0.0.1-retract: retracted by module author: Have go.mod on non-root, never meant to happen.
go: to switch to the latest unretracted version, run:
go get github.com/fishy/test-go-mod-retract/lib@latest
go get: added github.com/fishy/test-go-mod-retract/lib v0.0.1-retract
for examples.
But maybe we should just link to the git tag on github (https://github.com/apache/thrift/releases/tag/lib%2Fgo%2Fthrift%2Fv0.0.1-do-not-use, which does not exist yet but will be once we tagged it), and we can write more detailed messages (with links to both the go issue and THRIFT-5472) there. what do you think?
There was a problem hiding this comment.
I didn't know that retraction messages showed up on the cli, so yeah let's stick to a single line there and elaborate on the (future) release page.
fishy
force-pushed
the
retract-subdirectory-go-mod
branch
from
8beabe0
to
727da8e
Compare
fishy
changed the title
fishy
force-pushed
the
retract-subdirectory-go-mod
branch
from
727da8e
to
68d13b1
Compare
Currently when people going to https://pkg.go.dev/github.com/apache/thrift@v0.15.0/lib/go/thrift it shows that a previous version with lib/go/thrift/go.mod file is the latest version. With solution provided in golang/go#49015 (comment), this commit will NOT be merged, but tagged as `lib/go/thrift/v0.0.1-do-not-use`, in order to retract the bad version and make `v0.15.0` and the future versions as the correct latest version recognized by go toolchain. [skip ci]
fishy
force-pushed
the
retract-subdirectory-go-mod
branch
from
68d13b1
to
a62b40c
Compare
|
Tagged as https://github.com/apache/thrift/releases/tag/lib%2Fgo%2Fthrift%2Fv0.0.1-do-not-use, closing this PR. |
Currently when people going to
https://pkg.go.dev/github.com/apache/thrift@v0.15.0/lib/go/thrift it
shows that a previous version with lib/go/thrift/go.mod file is the
latest version.
With solution provided in
golang/go#49015 (comment), this
commit will NOT be merged, but tagged as
lib/go/thrift/v0.0.1-do-not-use, in order to retract the bad versionand make
v0.15.0and the future versions as the correct latest versionrecognized by go toolchain.
[skip ci]