New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5486 : fix issues found by spotbugs #2484

Merged

Jens-G merged 2 commits into apache:master from bhalchandrap:thrift-5486

Dec 13, 2021

Contributor

bhalchandrap commented Dec 2, 2021

Fixes the following issues found by spotbugs:

Private method org.apache.thrift.partial.ThriftMetadata$ThriftPrimitive.getParentStruct() is never called
Private method org.apache.thrift.TDeserializer.createNewStruct(ThriftMetadata$ThriftStruct) is never called
org.apache.thrift.partial.PartialThriftComparer.areEqual(ThriftMetadata$ThriftMap, Object, Object, StringBuilder) makes inefficient use of keySet iterator instead of entrySet iterator

kpandit and others added 2 commits

December 2, 2021 14:15


          THRIFT-5486 : fix issues found by spotbugs

f67a4cc


          Merge branch 'apache:master' into thrift-5486

6af5e16

Jens-G merged commit c6c5a05 into apache:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment