New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THRIFT-5574: add ubuntu focal build #2528
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
Still broken. Also there is a possible conflict with #2541 ahead. |
yes so let me wait for that to merge first and then rebase & fix |
2e45739
to
46950ec
Compare
18e2bc2
to
4d703a9
Compare
12bd04e
to
4263b91
Compare
i think the latest CI fails because ubuntu:focal ships with openSSL 1.1.1f instead of 1.1.1 in e.g. xenial. This requires some test changes. |
cc @jeking3 the original author of |
26b26e6
to
5ad4035
Compare
probably need to be done after:
|
fd10a6a
to
012bd53
Compare
@Jens-G do you think this can be merged? the refresh script did run correctly. the main errors are the same with |
+1 |
012bd53
to
0c034b4
Compare
192a8f6
to
a28914e
Compare
I would really appreciate if we could squash commits that belong together again before merging. And label it with the ticket number, btw. |
thanks for the suggestion, i'd make sure to follow it next time. |
I just double checked that I indeed used GitHub's squash commit button, and the hash is f027dee which is a single commit onto master. it only shows here in the pull request as a multi-commit pull request while in the master branch it's one. Did i miss anything? |
[skip ci]
anywhere in the commit message to free up build resources.