Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5574: add ubuntu focal build #2528

Merged
merged 7 commits into from Sep 19, 2022
Merged

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Feb 22, 2022

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G
Copy link
Member

Jens-G commented Feb 26, 2022

The following packages have unmet dependencies:
 erlang : Depends: erlang-odbc
E: Unable to correct problems, you have held broken packages.
The command '/bin/sh -c apt-get install -y --no-install-recommends   `# Erlang dependencies`   erlang &&   wget https://s3.amazonaws.com/rebar3/rebar3 -O /usr/bin/rebar3 &&   chmod 755 /usr/bin/rebar3 &&   rebar3 --version' returned a non-zero code: 100

@Jens-G Jens-G self-requested a review March 6, 2022 11:50
Jens-G
Jens-G previously requested changes Mar 6, 2022
Copy link
Member

@Jens-G Jens-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@Jens-G
Copy link
Member

Jens-G commented Mar 7, 2022

Still broken. Also there is a possible conflict with #2541 ahead.

@jimexist
Copy link
Member Author

jimexist commented Mar 8, 2022

Still broken. Also there is a possible conflict with #2541 ahead.

yes so let me wait for that to merge first and then rebase & fix

@jimexist jimexist force-pushed the add-ubuntu-focal branch 2 times, most recently from 18e2bc2 to 4d703a9 Compare April 13, 2022 02:35
@jimexist jimexist force-pushed the add-ubuntu-focal branch 2 times, most recently from 12bd04e to 4263b91 Compare April 19, 2022 07:18
@jimexist
Copy link
Member Author

i think the latest CI fails because ubuntu:focal ships with openSSL 1.1.1f instead of 1.1.1 in e.g. xenial. This requires some test changes.

@jimexist
Copy link
Member Author

cc @jeking3 the original author of SecurityTest. The failing tests is https://app.travis-ci.com/github/apache/thrift/jobs/567449611 - i am not sure if we need to drop some support or need to update the way parameters are constructed

@jimexist jimexist force-pushed the add-ubuntu-focal branch 2 times, most recently from 26b26e6 to 5ad4035 Compare April 27, 2022 11:47
@jimexist jimexist changed the title add ubuntu focal build THRIFT-5574: add ubuntu focal build Apr 28, 2022
@jimexist
Copy link
Member Author

probably need to be done after:

@jimexist
Copy link
Member Author

@Jens-G do you think this can be merged? the refresh script did run correctly. the main errors are the same with master, i.e. Java errors, for which I'm trying to find time to fix.

@Jens-G
Copy link
Member

Jens-G commented Sep 12, 2022

+1

@jimexist
Copy link
Member Author

FYI @Jens-G @fishy or anyone who's interested, i'm merging this, given the current state of CI, i'd rather be iterating towards this (plus bionic) and move away from xenial.

@jimexist jimexist merged commit f027dee into apache:master Sep 19, 2022
@jimexist jimexist deleted the add-ubuntu-focal branch September 19, 2022 06:26
@Jens-G
Copy link
Member

Jens-G commented Sep 19, 2022

I would really appreciate if we could squash commits that belong together again before merging. And label it with the ticket number, btw.

@jimexist
Copy link
Member Author

I would really appreciate if we could squash commits that belong together again before merging. And label it with the ticket number, btw.

thanks for the suggestion, i'd make sure to follow it next time.

@jimexist
Copy link
Member Author

I would really appreciate if we could squash commits that belong together again before merging. And label it with the ticket number, btw.

I just double checked that I indeed used GitHub's squash commit button, and the hash is f027dee which is a single commit onto master. it only shows here in the pull request as a multi-commit pull request while in the master branch it's one. Did i miss anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants