THRIFT-5526: java gen to use private_members instead of private-members as a consistent param casing #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
changed the title
|
You are being aware that you are about to introduce a breaking change? Proposal: Accept both forms. |
Jens-G
requested changes
Feb 22, 2022
Hi @Jens-G thanks for the suggestion. in fact it's not a breaking change, as in https://github.com/apache/thrift/pull/2531/files#diff-c59dffe78e4250a1f0450c496300e137aa1631b60488108e237a292a1c2e6789R81-R82 both forms are indeed accepted. however do you think i should include this information in the document ( |
jimexist
force-pushed
the
fix-private-members
branch
from
f878b85
to
2a1fd22
Compare
…stent param casing
jimexist
force-pushed
the
fix-private-members
branch
from
2a1fd22
to
ce6042b
Compare
jimexist
pushed a commit
to jimexist/thrift
that referenced
this pull request
Mar 3, 2022
…a consistent param casing Client: java Patch: Jiayu Liu This closes apache#2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java gen to use private_members instead of private-members as a consistent param casing
[skip ci]anywhere in the commit message to free up build resources.