Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5535 support creating connection on OpenHarmonyOS #2547

Merged
merged 1 commit into from Mar 13, 2022

Conversation

konpeki622
Copy link
Contributor

@konpeki622 konpeki622 commented Mar 11, 2022

Related to THRIFT-5535.

In a word, I modified lib/nodejs/lib/thrift/http_connection.js to support OpenHarmony OS data request API.

Maybe what you propose fits better under /contrib than in the general library.

OpenHarmony OS supports importing node.js module as dependency, and that this module required other node.js modules such as TJSONProtocol, so I still do that under nodejs lib.

Because OpenHarmony OS runs with the browserify environment, these interfaces were exported in browser.js.

It's hard to write test use case, but I created a demo for test. You can try it with npm link.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G Jens-G changed the title THRIFT-5535: [nodejs lib] support creating connection on OpenHarmonyOS THRIFT-5535 support creating connection on OpenHarmonyOS Mar 11, 2022
@Jens-G Jens-G merged commit bbea728 into apache:master Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants