Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5563: fix deprecation and enable xlint for java library #2575

Merged
merged 3 commits into from
Apr 18, 2022
Merged

THRIFT-5563: fix deprecation and enable xlint for java library #2575

merged 3 commits into from
Apr 18, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Apr 18, 2022 •
edited

fix deprecation and enable xlint for java library

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@jimexist jimexist changed the title fix deprecation and enable xlint for java library THRIFT-5563: fix deprecation and enable xlint for java library Apr 18, 2022
ctubbsii
ctubbsii reviewed Apr 18, 2022
View reviewed changes
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like good improvements

lib/java/gradle/sourceConfiguration.gradle Show resolved Hide resolved
lib/java/src/org/apache/thrift/partial/ThriftMetadata.java Outdated Show resolved Hide resolved
lib/java/src/org/apache/thrift/partial/ThriftMetadata.java Outdated Show resolved Hide resolved
@ctubbsii ctubbsii merged commit 6bdefc4 into apache:master Apr 18, 2022
@jimexist jimexist deleted the xwarning branch April 19, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctubbsii ctubbsii ctubbsii left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jimexist @ctubbsii