Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5558: Move JS-only tests from /test to /lib/js #2587

Closed
wants to merge 2 commits into from
Closed

THRIFT-5558: Move JS-only tests from /test to /lib/js #2587

wants to merge 2 commits into from

Conversation

Jimexist
Copy link
Member

@Jimexist Jimexist commented Apr 26, 2022 •
edited

Move JS-only tests from /test to /lib/js

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G Jens-G added the javascript Pull requests that update Javascript code label Oct 25, 2022
@Jens-G Jens-G added the rebase needed rebase needed label Nov 20, 2022
@Jimexist Jimexist closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmenlau emmenlau Awaiting requested review from emmenlau

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code rebase needed rebase needed
Projects
None yet
Milestone
No milestone
2 participants
@Jimexist @Jens-G