Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5583: Add skip_remote arg to go compiler #2604

Merged
merged 1 commit into from May 10, 2022
Merged

THRIFT-5583: Add skip_remote arg to go compiler #2604

merged 1 commit into from May 10, 2022

Conversation

fishy
Copy link
Member

@fishy fishy commented May 9, 2022

Client: go

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@fishy fishy marked this pull request as ready for review May 9, 2022 20:39
@fishy fishy requested a review from dcelasun May 9, 2022 20:39
@fishy fishy merged commit dae1437 into apache:master May 10, 2022
@fishy fishy deleted the go-skip-remote branch May 10, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcelasun dcelasun dcelasun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fishy @dcelasun