THRIFT-5649: add github action for go #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 8, 2022 19:00
jimexist
changed the title
|
the cross test failure is irrelevant to the changes in this pr |
fishy
reviewed
Oct 9, 2022
|
|
||
| - uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: '>=1.17.0' |
There was a problem hiding this comment.
the current supported go versions are 1.18.x and 1.19.x: https://github.com/apache/thrift/blob/master/LANGUAGES.md, not 1.17.x.
but looks like it actually picks the latest version (1.19.1) from the logs, so I think we probably actually need two actions, one for lib-go-1.18 with <1.19.0 and one for lib-go-1.19 with >=1.19.0, or something like that.
There was a problem hiding this comment.
thanks for the suggestion - will setup a new jira to follow up
There was a problem hiding this comment.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add github action for go
[skip ci]anywhere in the commit message to free up build resources.