Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5701: Add dependabot #2784

Merged
merged 4 commits into from Apr 27, 2023
Merged

THRIFT-5701: Add dependabot #2784

merged 4 commits into from Apr 27, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Apr 13, 2023

To keep up to date with the latest dependencies

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

To keep up to date with the latest dependencies
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea, but I would suggest making Java deps less frequent. Maybe monthly. Java dependencies can move pretty quickly, and I can imagine things getting spammy pretty quickly.

@Fokko
Copy link
Contributor Author

Fokko commented Apr 13, 2023

@ctubbsii Thanks for the quick response. How about weekly? I agree that we don't want too much spam, however, we don't want to miss any deprecations. Looking at other projects weekly is a good balance.

@Jens-G
Copy link
Member

Jens-G commented Apr 13, 2023

Don't we have dependabot already? And why only Java?

@ctubbsii
Copy link
Member

@ctubbsii Thanks for the quick response. How about weekly? I agree that we don't want too much spam, however, we don't want to miss any deprecations. Looking at other projects weekly is a good balance.

It was already set to weekly when I made my comment. The GitHub Actions were set to daily. I don't think those change very often, so that doesn't really matter.

My main concern about doing the Java libs weekly, is that this only really matters for release and release testing, and this project doesn't release very often. So, this can just create a bunch of busy work... bumping dependencies every week, resulting in possibly several dozen bumps between releases. That can get annoying, because one bump during the development period would suffice. Frequent bumps can have benefits, in that slowly moving incompatibilities can be fixed more easily in smaller chunks... but more likely, these bumps will merely fix bugs and not create any incompatibilities at all. So, it's just busy work. I would choose a longer duration to match the less frequent release cycle of this project in order to avoid redundant busy work, and more ability to focus on the outstanding PRs that are more important for the project.

@Fokko
Copy link
Contributor Author

Fokko commented Apr 14, 2023

@Jens-G

Don't we have dependabot already? And why only Java?

Github does create PRs for bumping libraries that have security holes, but for the regular updates, you need to enable it explicitly by adding the file. I'm comfortable with Java, and I t think we can add more languages later on.

@ctubbsii I see your concern. My argument to that would be that you don't want to do all the updates just before a release as something might have broken you want to know earlier. I would argue that it will reduce the work because you don't have to look up the latest version, and you only have to merge the PR that's being created by Dependabot. As I said, I have seen this work well on other projects, and I would recommend giving it a try.

Copy link
Member

@jimexist jimexist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you also include /lib/kotlin

@Fokko
Copy link
Contributor Author

Fokko commented Apr 14, 2023

@jimexist done! 👍🏻

@Jens-G Jens-G added the ci label Apr 15, 2023
Copy link

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we consuming this?

@ctubbsii
Copy link
Member

Where are we consuming this?

If this is merged to the default branch, then GitHub will use it to automatically open pull requests to propose updates to dependencies that are tracked. See https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/

@Fokko
Copy link
Contributor Author

Fokko commented Apr 26, 2023

You can see it in action on the Parquet-mr repository: https://github.com/apache/parquet-mr/pulls

@jimexist jimexist merged commit 67de2f5 into apache:master Apr 27, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants