THRIFT-5711: Fix FutureClient implementation when service extends from another service #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
future_client
branch
from
23bf13d
to
787514b
Compare
jimexist
approved these changes
May 18, 2023
|
change looks good to me but please fix the compile error first |
ctubbsii
reviewed
May 18, 2023
|
I went ahead and fixed the compile error for them, since it was just a missing close brace. I think it's good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FutureClientshould extend the parent serviceFutureClientbecause theFutureIfacedoes that too. Without this change theFutureClientwill get a compilation error that does not implement all the methods.