THRIFT-5714 add TJSONProtocol support for swift #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code contains the changes required to support TJSONProtocol in the Thrift-Swift. The codes are ported from C#.NET Thrift official library
Jens-G
changed the title
Jens-G
requested changes
Jun 7, 2023
| // Created by Khodabakhsh, Hojjat on 5/18/23. | ||
| // | ||
|
|
||
| import XCTest |
There was a problem hiding this comment.
please replace the file header by std ASF license header
| import Foundation | ||
|
|
||
| public class TBase64Utils { | ||
| private static let EncodeTable: String = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/" |
There was a problem hiding this comment.
Do we really need to implement this ourselves? Does Swift have no standard runtime library support for this that we can leverage?
There was a problem hiding this comment.
I imported the code from C# library and the way it has been implemented is like above, so I wanted to be consistent with that.
see https://github.com/apache/thrift/blob/master/lib/netstd/Thrift/Protocol/Utilities/TBase64Utils.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code contains the changes required to support TJSONProtocol in the Thrift-Swift. The codes are ported from C#.NET Thrift official library
Add support TJSONProtocol via implementing it.
Jira Ticket: https://issues.apache.org/jira/browse/THRIFT-5714
[skip ci]anywhere in the commit message to free up build resources.