Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] reformat kotlin files to fix CI as the master branch is broken by it #2829

Merged
merged 2 commits into from Jul 16, 2023
Merged

[CI] reformat kotlin files to fix CI as the master branch is broken by it #2829

merged 2 commits into from Jul 16, 2023

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jul 5, 2023 •
edited

reformat kotlin files to fix CI as the master branch is broken by it.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@jimexist jimexist changed the title reformat kotlin files [CI] reformat kotlin files to fix CI as the master branch is broken by it Jul 5, 2023
@Jens-G Jens-G added the kotlin label Jul 7, 2023
@jimexist jimexist mentioned this pull request Jul 8, 2023
Merged
fishy
fishy approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@fishy fishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Jens-G Jens-G merged commit a4e1136 into master Jul 16, 2023
27 of 50 checks passed
@ctubbsii ctubbsii deleted the fix-kotlin-format branch October 20, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishy fishy fishy approved these changes

@ctubbsii ctubbsii ctubbsii approved these changes

Assignees
No one assigned
Labels
kotlin
Projects
None yet
Milestone
No milestone
4 participants
@jimexist @fishy @ctubbsii @Jens-G