THRIFT-5725: Fix the comparison check for bio_get_fd #2831
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routine bio_get_fd checks for the validity of a file descriptor by comparing the fd to be less
than or equal to zero. The issue is that fd of 0 is a valid file descriptor. This PR changes the check
to be less than zero.
[skip ci]
anywhere in the commit message to free up build resources.