Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5725: Fix the comparison check for bio_get_fd #2831

Closed
wants to merge 1 commit into from

Conversation

psarkar24
Copy link

The routine bio_get_fd checks for the validity of a file descriptor by comparing the fd to be less
than or equal to zero. The issue is that fd of 0 is a valid file descriptor. This PR changes the check
to be less than zero.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@fishy fishy added the c++ label Jul 7, 2023
@Jens-G
Copy link
Member

Jens-G commented Jul 7, 2023

+1 good catch

@psarkar24
Copy link
Author

@Jens-G If the patch looks good to you, can you please merge the changes? Thanks!

@Jens-G Jens-G closed this in bccca93 Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants