Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-3094 fix broken cmake build of C++ library with alternate threading #439

Conversation

jeking3
Copy link
Contributor

@jeking3 jeking3 commented Apr 13, 2015

No description provided.

@jeking3
Copy link
Contributor Author

jeking3 commented Apr 13, 2015

I guess this was merged through Hudson, as a result I am closing this. Sometimes they close automatically, and sometimes they do not, and I have no idea why...

@jeking3 jeking3 closed this Apr 13, 2015
@Jens-G
Copy link
Member

Jens-G commented Apr 13, 2015

. Sometimes they close automatically, and sometimes they do not, and I have no idea why...

They are closed when the magic line This closes <number> is in the commit message. If the committer does not add this (or forgets it) then nothing happens.

@jeking3
Copy link
Contributor Author

jeking3 commented Apr 13, 2015

Are we using the github "merge pull request" mechanism that appears in each pull request here, or are we forced to use some other means to commit changes?

@Jens-G
Copy link
Member

Jens-G commented Apr 13, 2015

@jeking3
Copy link
Contributor Author

jeking3 commented Apr 13, 2015

Thanks - the manual steps in this process are less than ideal, and Apache should consider tighter integration to resolve.

@jfarrell
Copy link
Contributor

hey @jeking3, Github is only a mirror of the actual Apache repos which are located at 1. There is a requirement that the canonical source for Apache repos must reside on ASF controlled servers and that they be the authority for commits. We have all the available Github integrations enabled for our project, but the merge button is not an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants