THRIFT-557 charset problem with file Autogenerated by Thrift #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrift issues THRIFT-557
collinmsn
changed the title
* upstream/master: THRIFT-2850 CMake for Apache Thrift
|
Correct me if I'm wrong, but isn't the "magic comment" expected to have a very specific format? The patch seems not to provide that ... although the examples below say something different compared to the text above. Any Pythonians around? |
|
Do you mean the comment this commit added is not any form of the following? |
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
Client: Python Patch: zhenghuabin <zhenghuabin@bytedance.com> This closes apache#601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix the issue https://issues.apache.org/jira/browse/THRIFT-557