Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile error(Windows7 x64) : there is no lib\cpp\src\thrift\Thri… #739

Closed
wants to merge 2 commits into from
Closed

fix compile error(Windows7 x64) : there is no lib\cpp\src\thrift\Thri… #739

wants to merge 2 commits into from

Conversation

lizhenghn123
Copy link

  • fix compile error(Windows7 x64) : there is no lib\cpp\src\thrift\Thrift.cpp file.

@kcris
Copy link
Contributor

kcris commented Dec 16, 2015

seems incomplete, see pull request #745
until more files are added to the vcxproj, this will still result in link errors

@lizhenghn123
Copy link
Author

add TProtocol.cpp and TOutput.cpp in libthrift.vcxproj

@kcris
Copy link
Contributor

kcris commented Dec 18, 2015

I did. I have both removed Thrift.cpp from the project file, and also added TProtocol.cpp and TOutput.cpp (see pull request #745, was merged already).
So this pr (#739) should be closed I think.

@lizhenghn123
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lizhenghn123 @kcris