Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hpa): Allow setting apiVersion through values file #9

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

stijnbrouwers
Copy link
Contributor

With K8s v1.25 being available, the HPA apiVersion has changed.

apiVersion: autoscaling/v2beta1

is deprecated in favour of

apiVersion: autoscaling/v2

The change still uses the same default value for the apiVersion as before (since not everyone will have migrated to v1.25 yet) but it's now possible to change the value through the values-file

@stijnbrouwers
Copy link
Contributor Author

FYI, @lewismc

@lewismc lewismc merged commit 436d6e2 into apache:main Mar 3, 2023
@lewismc
Copy link
Member

lewismc commented Mar 3, 2023

Excellent @stijnbrouwers thanks.
Same question as I asked @frascu , when I make the new Helm Chart release, should we align the Helm Chart version with the upstream Dockerhub tika version or simply make it latest-full? Any thoughts...? Ideally I would like to automate the Helm Chart releases based on new upstream Docker releases but I don't really have time to implement that right now.

@stijnbrouwers
Copy link
Contributor Author

@lewismc, personnaly, I like the appVersion in the chart.yaml file to be equal to the tika version that's being used by default. Keeping the chart version in sync is not necessary and maybe even difficult or impossible since there might be multiple chart updates during a single version.

An automatic build based on the upstream would indeed be ideally, I'll try to keep it in mind for a nice future project since I don't have the time for it atm either :-)

Thanks for merging btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants