Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIKA-1735 - add AC1027 and AC1032 and add ability to use dwgread if it is installed. #395

Closed
wants to merge 14 commits into from

Conversation

nddipiazza
Copy link
Contributor

@nddipiazza nddipiazza commented Jan 9, 2021

Add parsing support for AC1027 and AC1032.
If dwgread is installed, use it to parse the document.

Test data is from https://github.com/LibreDWG/libredwg/tree/master/test/test-data/2018

TRT-PaulH and others added 9 commits November 11, 2020 10:34
No tests added for customprops.

Modified DWGParser.java to include version AC1027.

Added an example file to test AC1027.

Added an example file to test AC1032. However no modification to code included for AC1032.

Signed-off-by: TRT-PaulH <paul.henderson@raytheon.co.uk>
allow empty TDCREATE and TDMODIFIED
@nddipiazza nddipiazza changed the title TIKA-1735 - ac2017 and add ability to use dwgread if it is installed. TIKA-1735 - add AC1027 and AC1032 and add ability to use dwgread if it is installed. Jan 10, 2021
@tballison
Copy link
Contributor

I realize this will require quite a bit more refactoring. Would it make sense to create a new parser DWGExecParser that runs dwgread if it is installed, otherwise falls back to the current parser as it is? I worry that the new parser is a bit complex.

@nddipiazza
Copy link
Contributor Author

oops didn't see this coment until now. @tballison yes that is fine. I'll see if i can get this done this weekend.

@monkmachine
Copy link
Contributor

@nddipiazza just wondering if you got anywhere with this?

@nddipiazza
Copy link
Contributor Author

nddipiazza commented Feb 14, 2022

@monkmachine hi i did not end up needing this for my project and abandoned ship. you need it?
it needs a couple hours of effort applying the fixes tim suggested.

@monkmachine
Copy link
Contributor

@nddipiazza Yeah would be good, we're about to start doing some work with DWG's.

@monkmachine
Copy link
Contributor

@tballison this can be closed now as you've just merged my PR :)

@tballison
Copy link
Contributor

Closing because of merge of #558

@tballison tballison closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants