[TIKA-94] Speech-to-text transcription #406
Conversation
| /** | ||
| * Interface for Transcriber services. | ||
| * | ||
| * @since Tika TODO |
There was a problem hiding this comment.
Excellent. Thank you for adding this. We will populate it when we complete the pull request.
There was a problem hiding this comment.
Also please describe the interface.
| */ | ||
| public interface Transcriber { | ||
| /** | ||
| * @return |
There was a problem hiding this comment.
First, we need a description of the interface. This is REALLY important
Next we add parameters
Then we add @throws
then return
This method signature needs to change. It is too tighly coupled to the AWS transcribe input. Please model the interface on the tika-translate API.
| import static org.junit.Assert.fail; | ||
|
|
||
| public class AmazonTranscribeGuessLanguageTest { | ||
| AmazonTranscribe transcriber; |
There was a problem hiding this comment.
This should be
Transcribe transcriber;
| public void AmazonTranscribeGuessLanguageAudioLongTest() { | ||
| String expected = "where is the bus stop? where is the bus stop?"; | ||
| //TODO: "expected" should be changed to reflect the contents of LongAudioSample.mp3 | ||
| String audioFilePath = "src/test/resources/LongAudioSample.mp3"; |
There was a problem hiding this comment.
We create a resource folder in the test folder to store test file
| Necessary to get the correct file path from our test resource folder? */ | ||
| //TODO: is the above commented block necessary to obtain the proper filepath for a file located in the tika-translate/test/resources directory? | ||
|
|
||
| String audioFilePath = "src/test/resources/ShortAudioSample.mp3"; |
| public void AmazonTranscribeGuessLanguageShortVideoTest() { | ||
| String expected = "where is the bus stop? where is the bus stop?"; | ||
| //TODO: "expected" should be changed to reflect the contents of ShortVideoSample.mp4 | ||
| String videoFilePath = "src/test/resources/ShortVideoSample.mp4"; |
| public void AmazonTranscribeGuessLanguageLongVideoTest() { | ||
| String expected = "hello sir"; | ||
| //TODO: "expected" should be changed to reflect the contents of LongVideoSample.mp4 | ||
| String videoFilePath = "src/test/resources/LongVideoSample.mp4"; |
> refactored Transcriber interface
key -> jobName TODO add documentation for the methods
Updated POMs and link to Miredot docs.
…long with aliases for popular alternate mimetypes for it
Authored-by: Ryan <ryan@softnext.com> Thank you!
…ponents in TikaConfig as default. Still more cleanup necessary...
|
@tballison I know you and I spoke about refactoring this as simple a parser interface... |
This is a WIP on the work we are doing as fulfillment of the Hackillinois program.
We will be adding to this and I will be making comments in here.
Great work team on the work so far...