Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve download page #1059

Merged
merged 2 commits into from Feb 19, 2019
Merged

Improve download page #1059

merged 2 commits into from Feb 19, 2019

Conversation

spmallette
Copy link
Contributor

I didn't bother to create a ticket for this as it's more of a administrative thing, but I've reworked the download page to have a dropdown list of the archived versions. In that way, the page doesn't scroll so much and other content lower in the page is more immediately visible. This should also make our release days a bit less error prone in retiring old versions to archives as it's now just a matter of editing the dropdown to include the archived versions - easier that cut/paste.

What I have is functional though perhaps not awesome in terms of jquery/bootstrap/js so if this can be improved please let me know. I feel like I've tested pretty well, but it would be great if a few folks could bin/generate-home.sh and try the mechanics out directly.

VOTE +1

Added dropdown to handle archives so that the page didn't scroll so much and so that other content lower in the page was more immediately visible
@robertdale
Copy link
Member

The current instructions are:

https://tinkerpop.apache.org/docs/current/dev/developer/#_pmc_vote

PMC Vote
4. d. Update Downloads page, when moving "Current Releases" to "Archived Releases" recall that the hyperlink must change to point to version in the Apache Archives.

With this, we would just add a new <option> line and not have to update the archive links, correct?

@spmallette
Copy link
Contributor Author

yes - i will update that before i merge.

@dkuppitz
Copy link
Contributor

Looks, good, much cleaner now. I haven't tested all the links, but I picked out some random releases and all links worked as expected.

VOTE +1

@robertdale
Copy link
Member

Firefox renders the dropdown as black.

image

@robertdale
Copy link
Member

I pushed a fix. Looks like there is no 'bootstrap-select' class. I changed it to use the standard bootstrap form/select - https://getbootstrap.com/docs/3.3/css/#forms-controls

@spmallette spmallette merged commit 197dbc7 into master Feb 19, 2019
@spmallette spmallette deleted the download-page branch February 19, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants