TINKERPOP-2199 Fixed P.within()/without() behavior in gremlin-python #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had to tack in a few more commits on this after doing #1107 which addresses this issue for JS. The additional commits basically just do the same for C# that was done for python on this PR, adds some more tests in Java and fixes the io docs for GraphSON 3.0 with respect to |
|
Nice, VOTE +1 |
Made behavior for varags usage consistent with what Java does. Was never really sure what to do with this, but after reviewing the Java implementation it prefers a Collection as a single argument and basically converts the varargs to Collection, so basically just doing the same thing here.
Needed to better deal with varargs to these methods and to match Java usage which basically just calls these methods with the Collection argument. Matches up more nicely now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2199
Made behavior for varags usage consistent with what Java does. Was never really sure what to do with this, but after reviewing the Java implementation it prefers a Collection as a single argument and basically converts the varargs to Collection, so basically just doing the same thing here.
builds with
mvn clean installVOTE +1