Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINKERPOP-1641 Kerberos support for python #1290

Merged
merged 12 commits into from
Sep 4, 2020
Merged

Conversation

spmallette
Copy link
Contributor

@vtslab
Copy link
Contributor

vtslab commented May 30, 2020

I agree with this comment on the original PR:
"I do think the hardcoded "3.5.0-SNAPSHOT" in docker-entrypoint.sh needs to be dynamically referenced."
From the docker/gremlin-server/Dockerfile.template a GREMLIN_SERVER_VERSION variable is available from the environment. So, the offending line in docker-entrypoint.sh should read:
java -cp /opt/gremlin-test/gremlin-test-${GREMLIN_SERVER_VERSION}-jar-with-dependencies.jar \
While testing this I found that docker/gremlin_server.sh did not run and I do not understand how it ever can have worked. Anyway, docker needs absolute paths for the mounts and I think the docker run line should read:

ABS_PROJECT_HOME=$(dirname $(realpath $0))/..
docker run ${TINKERPOP_TEST_DOCKER_OPTS} ${REMOVE_CONTAINER} -h gremlin-server-test -v "${HOME}"/.groovy:/root/.groovy \
    -v "${HOME}"/.m2:/root/.m2 -v "${ABS_PROJECT_HOME}"/gremlin-test/target:/opt/gremlin-test -ti tinkerpop:${BUILD_TAG} ${@}

If you want I can put it in a PR against branch TINKERPOP-1641

@spmallette
Copy link
Contributor Author

I've pushed the changes you suggested. Docker looks better now.

VOTE +1

@vtslab
Copy link
Contributor

vtslab commented Jun 9, 2020

Great
VOTE +1

@spmallette
Copy link
Contributor Author

It was suggested to me separately that we look to enhance the Client API as we keep just expanding its construction with new keywords. No need to do it for this PR - I've created an issue for discussion:

https://issues.apache.org/jira/browse/TINKERPOP-2382

@spmallette
Copy link
Contributor Author

@vtslab sorry this one is still not merged - i'd like to get #1299 in first then look to merging this.

@spmallette
Copy link
Contributor Author

I rebased this now that #1299 merged but now i'm getting failures with docker builds. need to investigate that further. the spark failures seem common now on travis for some reason...they seem to take longer than the 50 minute limit despite us not adding any additional tests recently. probably need to look into that as well.

@spmallette
Copy link
Contributor Author

Rebased this on master - had to add an extra commit to cover issues with the removal of the templating system for GLVs. Still have to look into the docker issues and travis/spark build problems.

HadoopMarc and others added 12 commits September 1, 2020 14:33
Makes availeble KdcFixture in the docker container for testing GLV's

Adds kerberos authentication to gremlin-python

Adds tests for gremlin-python with kerberos

Adds audit logging to bytecode traversals (remnant from TINKERPOP-1566)

Updates the documentation

Updates the changelog
… apt packages in travis and there are no tests for the tornado functionality
Kirby was conflicting with neo4j
Remove hardcoded version from test path.
@spmallette
Copy link
Contributor Author

Docker problems seem resolved now for some reason. I wonder if I ran afoul of an out-of-date docker image. Travis failures around spark still seem spread about. Restarted some travis builds that failed.

@spmallette spmallette merged commit 94e01f6 into master Sep 4, 2020
@spmallette spmallette deleted the TINKERPOP-1641 branch September 4, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants