ResultSet.hasNext should be idempotent

[robertdale]

Sorry I didn't create a ticket; JIRA is having problems.

Calling hasNext() multiple times would dequeue items.

[spmallette]

This looks like a good change. Thanks for this. Did you run the Gremlin Server integration tests after making this change?

[robertdale]

Yes, I ran 'mvn clean install -DskipIntegrationTests=false -DincludeNeo4j' and it passed.

[spmallette]

VOTE +1

[dkuppitz]

VOTE: +1

[spmallette]

@robertdale when we get the final vote for this PR to be merged, i expect to merge it to tp31 and then master as I'd like the 3.1.x line of code to get this fix. i only mention this because i see that you now have what looks like an empty merge commit on this PR at this point. Do you know what that is? Is that something you can clean up from your end?

note to the final voter - i will update changelog on merge.

[robertdale]

I merged your master into my fork. Commit 0787e46
I didn't realize it would affect the pull request. Next time I'll create a branch.

[spmallette]

You could just use git rebase to update your branch rather than git merge - in that way the commit history doesn't get weird.

[robertdale]

Normally that's what I would do but tried doing it the 'github way' - https://help.github.com/articles/syncing-a-fork/

So let me know what you want me to do now. I can start over, creating the JIRA ticket, branch, etc.

[spmallette]

no need to start over - maybe not an issue. i'll see what happens when i merge. thanks

[okram]

Smart. VOTE +1.