TINKERPOP-1471: IncidentToAdjacentStrategy use hidden marker to avoid repeated recursion.

[okram]

https://issues.apache.org/jira/browse/TINKERPOP-1471

Hidden labels can be used by strategies as a way to communicate between "layers" of the compilation tree. This model is now applied to IncidentToAdjacentStrategy where if the traversal (as a whole) should NOT be processed by IncidentToAdjacentStrategy, then each traversal in the tree is "marked." If the traversal can be processed by IncidentToAdjacentStrategy, then there is no need to mark the traversals. This removes the need to, for every traversal, do a recursion from the parent traversal looking for invalidating step classes.

VOTE +1.

[dkuppitz]

VOTE: +1

A little refactoring would be nice though:

for (final Step<?, ?> step : traversal.getSteps()) {
    if (step instanceof TraversalParent) {
        ((TraversalParent) step).getLocalChildren().forEach(this::addLabelMarker);
        ((TraversalParent) step).getGlobalChildren().forEach(this::addLabelMarker);
    }
}

... should be as easy as:

TraversalHelper.forEachNestedTraversal(traversal, this::addLabelMarker);

[dkuppitz]

vertexCriterion can be null. In that case TraversalHelper.applyTraversalRecursively and/or the consumer would throw a NPE.

[okram]

? -- look at line 107 -- if(null != this.vertexCriteria)

[dkuppitz]

Ha, it's getting late here.....

[spmallette]

All tests pass with docker/build.sh -t -n -i

VOTE +1