TINKERPOP-1389 Limit JVM system props passed around in Spark jobs #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, SGC indiscriminately set the entire job config as JVM system properties on Spark executors. It didn't account for the fact that some config values (e.g. spark.job.description) could have spaces. A value with a space wouldn't get quoted. This led to Spark workers failing to start, because part of the unquoted value would be erroneously interpreted as the JVM main class. This commit makes SGC only pass two config settings as system props: * gremlin.io.registry * gremlin.io.kryoShimService
dalaro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, SGC indiscriminately set the entire job config
as JVM system properties on Spark executors. It didn't account for
the fact that some config values (e.g. spark.job.description) could
have spaces. A value with a space wouldn't get quoted. This led to
Spark workers failing to start, because part of the unquoted value
would be erroneously interpreted as the JVM main class.
This commit makes SGC only pass two config settings as system props: