Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINKERPOP-1872 Apply edgeFunction in SparkMessenger #788

Closed
wants to merge 1 commit into from

Conversation

Stargazer4869
Copy link

Re-create the pull request to replace the one on master branch.
The edgeFunction defined in Local MessageScope will not be applied anywhere when you are using SparkGraphComputer. It will cause a difference in result with what you will have when you are using TinkerGraphComputer.

@spmallette
Copy link
Contributor

sorry, it too me a while to get to this. It looks like you have a good unit tests for SparkMessenger but is there an integration test that would also work so that it could be added to the general test suite. In this way we could see it executed against TinkerMessenger and potentially other places where an edgeFunction might be in use?

@Stargazer4869
Copy link
Author

Hi, @spmallette
Is there an integration test case which involved TinkerMessenger or TinkerGraphComputer? I could write a similar one for SparkGraphComputer. It will make it easier for me to create an integration test case for SparkMessenger

@spmallette
Copy link
Contributor

Please see #793 which contains your changes here plus an integration test i was able to write to produce the problem. I wasn't sure how to advise you to do it, without doing it myself, so I hope you don't mind my finishing this one up for you. Please close this pull request when you get a moment...thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants