Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows set activation properties on a per-container basis. [backport] #90

Closed
wants to merge 2 commits into from
Closed

Allows set activation properties on a per-container basis. [backport] #90

wants to merge 2 commits into from

Conversation

otaviojava
Copy link
Contributor

@otaviojava otaviojava commented Jul 12, 2017 •
edited
Loading

Set activation properties on a per-container basis. This change makes activation properties belongs to a specific container.

  <Container id="MDB2" ctype="MESSAGE">
    ResourceAdapter MyOTHERResourceAdapter
    ActivationSpecClass My.Other.ActivationSpecImpl
   activation.property1 = othervalue1
   activation.property2 = othervalue2
  </Container>

I'll belong just to a container whose the id is MDB2 otherwise will ignore.

SvetlinZarev
SvetlinZarev reviewed Jul 17, 2017
View reviewed changes
container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java Outdated

T removed = null;
if (value == null) {
removed = (T) components.get(type);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove() returns the removed value, so no need for both get() and remove()

@jgallimore
Copy link
Contributor

@otaviojava this got merged in a different PR - can you close this one?

@otaviojava otaviojava closed this Jul 25, 2017
@otaviojava
Copy link
Contributor Author

Done

@otaviojava otaviojava deleted the add_message_activation_container_backport branch July 25, 2017 11:24
jgallimore added a commit to jgallimore/tomee that referenced this pull request Mar 4, 2019
@jgallimore
Merge pull request apache#90 from jgallimore/tomee-7.1.x-TT.x-updates
0b827d5 
Update ActiveMQ, Jackson Databind and Tomcat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvetlinZarev SvetlinZarev SvetlinZarev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@otaviojava @jgallimore @SvetlinZarev