[TOMEE-4053] Dependency properties cleanup, step 3 on branch 9.x #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sultan
force-pushed
the
properties_9.x
branch
from
35256df
to
1249f90
Compare
|
rebased upon tomee-9.x please review |
|
this PR is intended for latest 9.X should i target main branch or tomee-9.x branch ? |
|
You are correct, it is for 9.x so the tomee-9.x branch is the one to use. You did great. Should I cherry pick or try to move it to main (aka TomEE 10.x) or do you plan to do it there as well? |
|
not sure the cherry pick will get all the properties in the right place. i can do that on 10.x/main later on |
@jeanouii step 3 on branch 10.x here : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this one is about tck tests and microprofile api & impl.
thanks @jeanouii for the wss4j merge
some of our TCK modules depend directly on smallrye impl. is it intendend ?