Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOMEE-4053] Dependency properties cleanup, step 3 : Micro Profile properties on branch 10.x #997

Merged
merged 1 commit into from Feb 7, 2023

Conversation

sultan
Copy link
Contributor

@sultan sultan commented Jan 4, 2023

[TOMEE-4053] Dependency properties cleanup, step 3 : Micro Profile properties on branch main/10.x

Edit: now without changes to the versions numbers

@sultan sultan marked this pull request as draft January 4, 2023 15:28
@sultan sultan force-pushed the properties_10.x branch 2 times, most recently from 96ffb34 to 0d8dcbd Compare January 4, 2023 16:04
@sultan sultan changed the title [TOMEE-4140] Update MicroProfile to 6.0 [TOMEE-4053] Dependency properties cleanup Jan 31, 2023
@sultan sultan force-pushed the properties_10.x branch 7 times, most recently from 332d713 to 5451f25 Compare January 31, 2023 07:39
@sultan sultan changed the title [TOMEE-4053] Dependency properties cleanup [TOMEE-4053] Dependency properties cleanup and [TOMEE-4140] Update Micro Profile from 5.0 to 6.0 Jan 31, 2023
@sultan sultan marked this pull request as ready for review January 31, 2023 07:52
@rzo1
Copy link
Contributor

rzo1 commented Jan 31, 2023

Does th MP 6.0 TCK pass? If not, we should do the property cleanup and afterwards update to a (passing) MP6

@sultan sultan changed the title [TOMEE-4053] Dependency properties cleanup and [TOMEE-4140] Update Micro Profile from 5.0 to 6.0 [TOMEE-4053] Dependency properties cleanup, step 3 : Micro Profile properties on branch main/10.x Jan 31, 2023
@sultan
Copy link
Contributor Author

sultan commented Jan 31, 2023

Does th MP 6.0 TCK pass? If not, we should do the property cleanup and afterwards update to a (passing) MP6

i cant run the TCK at the moment. I split the PR into separate PRs

this one is for the properties names changes. without versions number changes

@rzo1
Copy link
Contributor

rzo1 commented Feb 7, 2023

I think, that the target should be #1005

@sultan sultan changed the base branch from main to UpdateJakartaEEApi10 February 7, 2023 09:39
@sultan
Copy link
Contributor Author

sultan commented Feb 7, 2023

@rzo1 rebased and merged

@jeanouii jeanouii merged commit d38bc08 into apache:UpdateJakartaEEApi10 Feb 7, 2023
@jeanouii
Copy link
Contributor

jeanouii commented Feb 7, 2023

Thanks @sultan

@sultan sultan deleted the properties_10.x branch February 7, 2023 10:19
@sultan sultan changed the title [TOMEE-4053] Dependency properties cleanup, step 3 : Micro Profile properties on branch main/10.x [TOMEE-4053] Dependency properties cleanup, step 3 : Micro Profile properties on branch 10.x Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants