Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOMEE-4014 - Re-add "tomee.keep-server-info" #993

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Dec 19, 2022

as the title says

@rzo1 rzo1 requested a review from jgallimore December 19, 2022 09:08
@rzo1
Copy link
Contributor Author

rzo1 commented Dec 19, 2022

@jgallimore Judging from the answer in the ticket, it seems sufficient to re-add the check on "tomee.keep-server-info".

@rzo1 rzo1 force-pushed the TOMEE-4014-8x branch 2 times, most recently from 56570ba to fc9baea Compare December 19, 2022 09:18
@rzo1 rzo1 force-pushed the TOMEE-4014-8x branch 2 times, most recently from 806bf84 to 660f43d Compare December 29, 2022 17:57
@rzo1
Copy link
Contributor Author

rzo1 commented Dec 29, 2022

@jgallimore Switched from System.getProperties() to the original code using the SystemInstance#getOptions(), so it should be compatible to the way it previously worked.

@rzo1 rzo1 merged commit 14a034c into tomee-8.x Jan 4, 2023
@rzo1 rzo1 deleted the TOMEE-4014-8x branch January 16, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant