Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP - when generating a cert for a DS, the common name field should be editable #1605

Closed
mitchell852 opened this issue Nov 30, 2017 · 1 comment · Fixed by #1608
Closed

TP - when generating a cert for a DS, the common name field should be editable #1605

mitchell852 opened this issue Nov 30, 2017 · 1 comment · Fixed by #1608
Assignees
Labels
new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1
Milestone

Comments

@mitchell852
Copy link
Member

mitchell852 commented Nov 30, 2017

Currently, the common name is derived from routing name unless the DS is HTTP* where common name would include a wildcard (#1465) and the field is uneditable.

By making the common name field editable, you give the user more freedom to generate the cert as they desire.

https://localhost:8443/#!/delivery-services/:id/ssl-keys/generate

@mitchell852 mitchell852 added improvement Traffic Portal v1 related to Traffic Portal version 1 labels Nov 30, 2017
@mitchell852 mitchell852 self-assigned this Nov 30, 2017
@mitchell852 mitchell852 added this to the 2.2.0 milestone Jan 17, 2018
@rob05c rob05c added new feature A new feature, capability or behavior and removed improvement labels Jan 26, 2018
@mitchell852
Copy link
Member Author

This might have created a bug. Allowing the user to specify the common name when regenerating ssl keys for a delivery service will result in a key mismatch like this:

#1855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants