Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple migration test #2471

Closed
DylanVolz opened this issue Jun 26, 2018 · 1 comment · Fixed by #5652
Closed

simple migration test #2471

DylanVolz opened this issue Jun 26, 2018 · 1 comment · Fixed by #5652
Labels
automation related to automated testing/deployment/packaging etc. low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops

Comments

@DylanVolz
Copy link

We need a simple test that is ran on PRs to ensure that if a migration file is added it is of a date later than all other migrations in the directory. This is a problem we run into a lot when branches age too long.

@mitchell852 mitchell852 added new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one labels Jun 26, 2018
@mitchell852 mitchell852 added the automation related to automated testing/deployment/packaging etc. label Nov 17, 2020
@ocket8888
Copy link
Contributor

We have checks now that run on PRs to ensure that migrations

  • Are properly named (date-name.sql)
  • Have the right amount of date precision
  • Do not use duplicate dates

but we don't have a check for this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation related to automated testing/deployment/packaging etc. low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants