Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get request to api_capabilities using query values that don't exist return null #4257

Closed
2 of 16 tasks
ericholguin opened this issue Jan 6, 2020 · 1 comment
Closed
2 of 16 tasks
Assignees
Labels
regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops

Comments

@ericholguin
Copy link
Contributor

I'm submitting a ...

  • bug report
  • new feature / enhancement request
  • improvement request (usability, performance, tech debt, etc.)
  • other

Traffic Control components affected ...

  • CDN in a Box
  • Documentation
  • Grove
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • unknown

Current behavior:

When making a GET request to api_capabilities with any of the following query parameters with values that do not exist:

  • ?capability=DOESNTEXIST
  • ?route=DOESNTEXIST
  • ?id=100000000

Will return a null response:

HTTP\1.1 200 OK
{
    "response": null
}

Expected / new behavior:

Should return an empty array.

HTTP\1.1 200 OK
{
    "response": []
}

Minimal reproduction of the problem with instructions:

Anything else:

The capability query parameter is the only parameter that perl handled, and it would return an empty array. These other query parameters, should either be removed or should also return an empty array.

@ocket8888 ocket8888 self-assigned this Jan 6, 2020
@ocket8888 ocket8888 added bug something isn't working as intended regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops labels Jan 6, 2020
@mhoppa
Copy link
Contributor

mhoppa commented Feb 13, 2020

this was fixed in #4321 @mitchell852 @rawlinp @ocket8888 can you close

@rawlinp rawlinp closed this as completed Feb 13, 2020
@mitchell852 mitchell852 removed the bug something isn't working as intended label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops
Projects
None yet
Development

No branches or pull requests

5 participants