Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP and TO API are validating topology name differently #5161

Closed
dpham692 opened this issue Oct 16, 2020 · 2 comments · Fixed by #5236
Closed

TP and TO API are validating topology name differently #5161

dpham692 opened this issue Oct 16, 2020 · 2 comments · Fixed by #5236
Assignees
Labels
bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1

Comments

@dpham692
Copy link
Contributor

I'm submitting a ...

  • bug report

Traffic Control components affected ...

  • Traffic Ops

Current behavior:

Right now, user can create topologies with special characters like hyphen via Topologies API below.
https://{{TO_BASE_URL}}/api/3.0/topologies

Expected behavior:

TO should not let user create Topologies with special characters like hyphen

Minimal reproduction of the problem with instructions:

Do a POST https://{{TO_BASE_URL}}/api/3.0/topologies with this payload:

{
    "name":"name_hyphen_wrong",
    "description":"test",
    "nodes":
    [{
        "cachegroup":"albany-ny-usa",
        "parent":{"type":"ROOT"},
        "secParent":{"name":"","type":""},
        "parents":[]
    }]
}

Anything else:

@dpham692 dpham692 added the bug something isn't working as intended label Oct 16, 2020
@ocket8888
Copy link
Contributor

Or should TP's restrictions be relaxed?

@rawlinp
Copy link
Contributor

rawlinp commented Oct 16, 2020

I agree w/ @ocket8888 -- TP restrictions should be relaxed instead.

@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1 labels Oct 16, 2020
@mitchell852 mitchell852 added this to To do in Flexible Topologies via automation Oct 16, 2020
@mitchell852 mitchell852 removed the Traffic Ops related to Traffic Ops label Nov 3, 2020
Flexible Topologies automation moved this from To do to Done Nov 3, 2020
@mitchell852 mitchell852 self-assigned this Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants