Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP has "Link delivery services to server" button as well as under the "More" menu #5216

Closed
rawlinp opened this issue Oct 28, 2020 · 2 comments · Fixed by #5219
Closed

TP has "Link delivery services to server" button as well as under the "More" menu #5216

rawlinp opened this issue Oct 28, 2020 · 2 comments · Fixed by #5219
Labels
good first issue first-time committers will find this easy to resolve improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Oct 28, 2020

I'm submitting a ...

  • bug report

Traffic Control components affected ...

  • Traffic Portal

Current behavior:

TP has two buttons that both link delivery services to a server in the /#!/servers/id/delivery-services page:
image

Expected behavior:

The More menu item for linking delivery services to the server should be removed.

Minimal reproduction of the problem with instructions:

In your TP, go to /#!/servers/<your-server-ID>/delivery-services.
@rawlinp rawlinp added bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one good first issue first-time committers will find this easy to resolve labels Oct 28, 2020
@mitchell852
Copy link
Member

yeah, seems redundant but is it a bug? or did I do this on purpose? :) maybe it's an "improvement" instead?

@rawlinp rawlinp added improvement The functionality exists but it could be improved in some way. and removed bug something isn't working as intended labels Oct 28, 2020
@rawlinp
Copy link
Contributor Author

rawlinp commented Oct 28, 2020

Yeah, probably an improvement rather than a bug. I almost didn't open this because it seems so trivial 😄

@rimashah25 rimashah25 mentioned this issue Oct 29, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue first-time committers will find this easy to resolve improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed duplicate button to link delivery service to server rimashah25/trafficcontrol
2 participants
@mitchell852 @rawlinp