GET /servers?dsId={{nonexistent DS ID}} returns 403 forbidden

[zrhoffman]

I'm submitting a ...

• bug report

Traffic Control components affected ...

• Traffic Ops

Current behavior:

GET /servers?dsId={{dsId}} returns 403 forbidden when the dsId does not correspond to a Delivery Service that exists. Examples: 0, 99999999, etc.

{
	"alerts": [
		{
			"text": "Forbidden",
			"level": "error"
		}
	]
}

Expected behavior:

GET /servers?dsId=0 returns 200 OK with an empty array of servers

Minimal reproduction of the problem with instructions:

1. Log in
2. GET /api/4.0/servers?dsId=0 returns 200 OK with an empty array of servers

[mitchell852]

i guess its just doing the tenancy check huh? and ds=0 is in nobody's tenancy scope...hence the 403 Forbidden

[zrhoffman]

It returns 403 Forbidden for any non-existent dsId like 999999

[srijeet0406]

@zrhoffman I can take this one