Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/servercheck does not filter when extra query parameters are given #5609

Closed
ocket8888 opened this issue Mar 5, 2021 · 1 comment · Fixed by #5616
Closed

/servercheck does not filter when extra query parameters are given #5609

ocket8888 opened this issue Mar 5, 2021 · 1 comment · Fixed by #5616
Assignees
@rimashah25
Labels
bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops

Comments

@ocket8888
Copy link
Contributor

I'm submitting a ...

  • bug report

Traffic Control components affected ...

  • Traffic Ops

Current behavior:

GET requests to /servercheck can be filtered by ID and/or hostName, but if an extra query parameter is provided it breaks filtering. That is, GET /servercheck?id=1 returns only the serverchecks for server 1, but GET /servercheck?id=1&foo=bar returns all serverchecks for all servers.

Expected behavior:

The API should perform requested filtering and ignore all unrelated query parameters.

Minimal reproduction of the problem with instructions:

make a GET request to /servercheck with an id query string parameter set to the ID of some cache server, plus any other query parameter (except hostName, limit or offset) with any value.
@ocket8888 ocket8888 added bug something isn't working as intended Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one labels Mar 5, 2021
@rimashah25
Copy link
Contributor

i'll take this one.

@rimashah25 rimashah25 mentioned this issue Mar 8, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rimashah25 rimashah25

Labels
bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed GET /servercheck filtering for unknown and extra query param rimashah25/trafficcontrol
2 participants
@ocket8888 @rimashah25