Fix ORT TO minor fallback #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob05c
added
bug
rob05c
force-pushed
the
fix-ort-to-fallback
branch
from
b1c22fa
to
12e0d01
Compare
rob05c
force-pushed
the
fix-ort-to-fallback
branch
3 times, most recently
from
e7c5012
to
d9bbc44
Compare
rob05c
force-pushed
the
fix-ort-to-fallback
branch
from
d9bbc44
to
5b74c3e
Compare
|
Looks good testing in nightly lab 👍 |
jpappa200
approved these changes
Mar 19, 2021
|
Per our discussion, I think this PR is too deeply rooted in other large bodies of work to fit into the 5.1.1 patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Fixes ORT to fall back to previous Traffic Ops minor versions. This is necessary to make it possible to upgrade ORT before Traffic Ops.
We don't have a test framework capable of testing multiple TO versions yet. But the existing tests test the current version and validate it still works correctly.
Includes changelog.
No docs, no interface change.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run unit and integration tests, to verify the latest version still works.
Run ORT against the previous TO which doesn't have the latest minor, verify it still has features in the current major.
If this is a bug fix, what versions of Traffic Control are affected?
This has been a bug since ORT started using the TO client, around 3.0.
The following criteria are ALL met by this PR
Additional Information